Repository navigation
test Trailer Iterable overloads with non-List Iterables - #1383
Merged
Merged
Conversation
Motivation: The java.lang.Iterable overloads of Trailer.addHeaders and withHeaders (apache#1374) should accept any java.lang.Iterable, not just Lists. Modification: Run addHeaders/withHeaders with the same headers as an ArrayList, LinkedHashSet, ArrayDeque, unmodifiable Collection and a non-Collection Iterable. Add tests that the Iterable is traversed once and that withHeaders of an empty Iterable clears the headers. Result: The Trailer Java API overloads are tested with several Iterable shapes. Tests: - sbt "http-core/Test/testOnly org.apache.pekko.http.javadsl.model.TrailerTest" - passed References: Refs apache#1374, Refs apache#1378
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1374 added
java.lang.Iterableoverloads toTrailer.addHeaders/withHeaders, but its tests only passedLists. The overloads should accept anyjava.lang.Iterable.Modification
Test-only change to
TrailerTest:addHeaders/withHeaderswith the same headers as anArrayList,LinkedHashSet,ArrayDeque, unmodifiableCollectionand a non-CollectionIterable(items::iterator)Iterablethat fails on a second traversal, so the conversion must iterate only oncewithHeadersof an emptyIterableremoves all headersResult
The
TrailerJava API overloads are tested with severalIterableshapes, not justList.Tests
sbt "http-core/Test/testOnly org.apache.pekko.http.javadsl.model.TrailerTest": passed (7 tests)sbt http-core/Test/javafmtCheck(JDK 17): passedReferences
Refs #1374, Refs #1378